Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logabsgamma #72

Merged
merged 5 commits into from
Apr 5, 2024
Merged

add logabsgamma #72

merged 5 commits into from
Apr 5, 2024

Conversation

araujoms
Copy link
Contributor

Fixes #71

I've realized that it is not necessary to define loggamma, as the one from SpecialFunctions works when we provide a logabsgamma.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (24ec29b) to head (7d5b5b5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   77.36%   78.30%   +0.94%     
==========================================
  Files           3        3              
  Lines         349      355       +6     
==========================================
+ Hits          270      278       +8     
+ Misses         79       77       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalphAS RalphAS requested a review from devmotion March 29, 2024 14:41
src/specfun.jl Outdated Show resolved Hide resolved
Co-authored-by: RalphAS <[email protected]>
src/specfun.jl Outdated Show resolved Hide resolved
@RalphAS RalphAS merged commit 94e1f45 into JuliaMath:master Apr 5, 2024
12 checks passed
@araujoms araujoms deleted the gammainc branch April 5, 2024 05:49
@araujoms
Copy link
Contributor Author

araujoms commented Apr 5, 2024

Thanks. Could I ask you to also tag a new release? I want to call this function from DoubleFloats instead of copy-pasting code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compute incomplete gamma function for some arguments
3 participants